ChenKaiLiuG/life_generators
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Feat(fortune): Add new fortune events #47

Closed
tobiichi3227 wants to merge 1 commits from impr/new-fortunes into main
pull from: impr/new-fortunes
merge into: ChenKaiLiuG:main
Conversation 4 Commits 1 Files Changed 1 +19 -1
tobiichi3227 commented 2024-12-25 05:48:08 +00:00 (Migrated from github.com)
Copy Link

In this PR, we add some fortune events.
These events were provided by my classmate @ChenKaiLiuG.

In this PR, we add some fortune events. These events were provided by my classmate @ChenKaiLiuG.
lifeadventurer (Migrated from github.com) requested changes 2024-12-25 06:46:27 +00:00
lifeadventurer (Migrated from github.com) left a comment
Copy Link

Please polish all the added descriptions.

Please polish all the added descriptions.
tobiichi3227 commented 2024-12-25 07:34:58 +00:00 (Migrated from github.com)
Copy Link

Ummm.
Are you referring to explanation of this PR or fortune events?

Ummm. Are you referring to explanation of this PR or fortune events?
lifeadventurer commented 2024-12-25 11:42:57 +00:00 (Migrated from github.com)
Copy Link

Please polish all the added descriptions.

I was referring to the added descriptions. Some of the phrasing seems overly casual or too colloquial for the context. Could you revise these descriptions to use a more formal and professional tone that aligns with the project's style?

> Please polish all the **added descriptions**. I was referring to the **added descriptions**. Some of the phrasing seems overly casual or too colloquial for the context. Could you revise these descriptions to use a more formal and professional tone that aligns with the project's style?
tobiichi3227 commented 2024-12-25 11:59:53 +00:00 (Migrated from github.com)
Copy Link

@ChenKaiLiuG indicates to think it over again

@ChenKaiLiuG indicates to think it over again

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
lifeadventurer
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 stale
Pull Request is stale
 waiting for merge
waiting for review
waiting for update
wontfix
This will not be worked on
No Label stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ChenKaiLiuG
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ChenKaiLiuG/life_generators#47
Delete Branch "impr/new-fortunes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?