ChenKaiLiuG/life_generators
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix(Fortune): Incorrect time difference calculation for recent events #46

Merged
tobiichi3227 merged 2 commits from fix/event-diff-cal into main 2024-12-25 11:07:38 +00:00
Conversation 2 Commits 2 Files Changed 4 +73 -65
tobiichi3227 commented 2024-12-25 03:43:45 +00:00 (Migrated from github.com)
Copy Link

In this PR, we make two bugfixs.

  • Calculate the time difference for events that have already occurred based on the next year.
  • Put the Winter Solstice event into custom_special.json.
In this PR, we make two bugfixs. - Calculate the time difference for events that have already occurred based on the next year. - Put the Winter Solstice event into `custom_special.json`.
lifeadventurer (Migrated from github.com) approved these changes 2024-12-25 06:40:09 +00:00
lifeadventurer (Migrated from github.com) left a comment
Copy Link

You have sent pull requests to my open source project many times. Please remember to change your Pull Request title before I merge.

You have sent pull requests to my open source project many times. Please remember to change your Pull Request title before I merge.
tobiichi3227 commented 2024-12-25 07:15:33 +00:00 (Migrated from github.com)
Copy Link

Oh
I'm sorry.

Oh I'm sorry.
Sign in to join this conversation.
Reviewers
No Reviewers
lifeadventurer
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 stale
Pull Request is stale
 waiting for merge
waiting for review
waiting for update
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ChenKaiLiuG
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ChenKaiLiuG/life_generators#46
Delete Branch "fix/event-diff-cal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?