Feat(Fortune): Support multiple event in same day #61

2025-03-05T12:18:30Z

tobiichi3227 commented

2025-03-05 12:18:30 +00:00

(Migrated from github.com)

No description provided.

lifeadventurer (Migrated from github.com) requested changes 2025-03-05 15:57:26 +00:00

lifeadventurer (Migrated from github.com) left a comment

Please change the JSON file to adopt this feature.

scripts/check-events.py

						
				@@ -277,6 +277,12 @@ def check_static_date(event: dict, idx: int):

				            idx, trigger_date["date"], 1, DAYSPERMONTH[month], "triggerDate.date"

lifeadventurer (Migrated from github.com) commented

2025-03-05 15:55:59 +00:00

Extra quotation marks (") around the f-string are redundant and unnecessary.

scripts/check-events.py

						
				@@ -309,6 +315,12 @@ def check_cyclical_date(event: dict, idx: int):

				    validate_number(idx, trigger_date["week"], 1, 5, "triggerDate.week")

lifeadventurer (Migrated from github.com) commented

2025-03-05 15:55:48 +00:00

Extra quotation marks (") around the f-string are redundant and unnecessary.

scripts/check-events.py

						
				@@ -357,11 +369,11 @@ def check_custom_date(event: dict, idx: int):

				    if date is None:

lifeadventurer (Migrated from github.com) commented

2025-03-05 15:44:27 +00:00

Extra quotation marks (") around the f-string are redundant and unnecessary.

Extra quotation marks (`"`) around the f-string are redundant and unnecessary.

lifeadventurer (Migrated from github.com) requested changes 2025-03-06 04:42:35 +00:00

lifeadventurer (Migrated from github.com) left a comment

Please change the JSON file to adopt this feature.

You did not complete this comment from the last review in this updated submission.

> Please change the JSON file to adopt this feature. You did not complete this comment from the last review in this updated submission.

tobiichi3227 commented

2025-03-06 05:45:12 +00:00

(Migrated from github.com)

Please change the JSON file to adopt this feature.

You did not complete this comment from the last review in this updated submission.

The JSON file does not need to change since there are no mulitple events.
If we want to add multiple events, it should not be included in this PR

> > Please change the JSON file to adopt this feature. > > You did not complete this comment from the last review in this updated submission. The JSON file does not need to change since there are no mulitple events. If we want to add multiple events, it should not be included in this PR

lifeadventurer (Migrated from github.com) approved these changes 2025-03-06 06:22:56 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ChenKaiLiuG/life_generators#61

				`@@ -277,6 +277,12 @@ def check_static_date(event: dict, idx: int):`
				`idx, trigger_date["date"], 1, DAYSPERMONTH[month], "triggerDate.date"`

				`@@ -309,6 +315,12 @@ def check_cyclical_date(event: dict, idx: int):`
				`validate_number(idx, trigger_date["week"], 1, 5, "triggerDate.week")`

				`@@ -357,11 +369,11 @@ def check_custom_date(event: dict, idx: int):`
				`if date is None:`