ChenKaiLiuG/life_generators
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Feat(Fortune): Support multiple event in same day #61

Merged
tobiichi3227 merged 3 commits from feat/multiple-event into main 2025-03-06 06:23:03 +00:00
Conversation 4 Commits 3 Files Changed 3 +27 -6
tobiichi3227 commented 2025-03-05 12:18:30 +00:00 (Migrated from github.com)
Copy Link
No description provided.
lifeadventurer (Migrated from github.com) requested changes 2025-03-05 15:57:26 +00:00
lifeadventurer (Migrated from github.com) left a comment
Copy Link

Please change the JSON file to adopt this feature.

Please change the JSON file to adopt this feature.
scripts/check-events.py
@@ -277,6 +277,12 @@ def check_static_date(event: dict, idx: int):
idx, trigger_date["date"], 1, DAYSPERMONTH[month], "triggerDate.date"
lifeadventurer (Migrated from github.com) commented 2025-03-05 15:55:59 +00:00
Copy Link

Extra quotation marks (") around the f-string are redundant and unnecessary.

Extra quotation marks (") around the f-string are redundant and unnecessary.
scripts/check-events.py
@@ -309,6 +315,12 @@ def check_cyclical_date(event: dict, idx: int):
validate_number(idx, trigger_date["week"], 1, 5, "triggerDate.week")
lifeadventurer (Migrated from github.com) commented 2025-03-05 15:55:48 +00:00
Copy Link

Extra quotation marks (") around the f-string are redundant and unnecessary.

Extra quotation marks (") around the f-string are redundant and unnecessary.
scripts/check-events.py
@@ -357,11 +369,11 @@ def check_custom_date(event: dict, idx: int):
if date is None:
lifeadventurer (Migrated from github.com) commented 2025-03-05 15:44:27 +00:00
Copy Link

Extra quotation marks (") around the f-string are redundant and unnecessary.

Extra quotation marks (`"`) around the f-string are redundant and unnecessary.
lifeadventurer (Migrated from github.com) requested changes 2025-03-06 04:42:35 +00:00
lifeadventurer (Migrated from github.com) left a comment
Copy Link

Please change the JSON file to adopt this feature.

You did not complete this comment from the last review in this updated submission.

> Please change the JSON file to adopt this feature. You did not complete this comment from the last review in this updated submission.
tobiichi3227 commented 2025-03-06 05:45:12 +00:00 (Migrated from github.com)
Copy Link

Please change the JSON file to adopt this feature.

You did not complete this comment from the last review in this updated submission.

The JSON file does not need to change since there are no mulitple events.
If we want to add multiple events, it should not be included in this PR

> > Please change the JSON file to adopt this feature. > > You did not complete this comment from the last review in this updated submission. The JSON file does not need to change since there are no mulitple events. If we want to add multiple events, it should not be included in this PR
lifeadventurer (Migrated from github.com) approved these changes 2025-03-06 06:22:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
lifeadventurer
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 stale
Pull Request is stale
 waiting for merge
waiting for review
waiting for update
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ChenKaiLiuG
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ChenKaiLiuG/life_generators#61
Delete Branch "feat/multiple-event"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?