ChenKaiLiuG/life_generators
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Impr(special): Add new special events for January and February #48

Merged
tobiichi3227 merged 1 commits from impr/new-events into main 2025-02-06 13:08:52 +00:00
Conversation 12 Commits 1 Files Changed 1
+204 -4
tobiichi3227 commented 2025-01-12 04:26:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

In this PR, we add some special events
These holidays and descriptions were proposed by me, @ChenKaiLiuG, and other classmates.

In this PR, we add some special events These holidays and descriptions were proposed by me, @ChenKaiLiuG, and other classmates.
lifeadventurer commented 2025-01-13 11:15:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I noticed there isn't a mechanism to handle multiple events occurring on the same day, so only one event is chosen. There are two events scheduled on the same day, February 28th.

I noticed there isn't a mechanism to handle multiple events occurring on the same day, so only one event is chosen. There are two events scheduled on the same day, February 28th.
tobiichi3227 commented 2025-01-13 13:20:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Ok.
I fixed

Ok. I fixed
lifeadventurer commented 2025-01-13 15:02:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I mean there can be many events on the same day but we need a mechanism that can decide which event to go to instead of just following the order now.

I mean there can be many events on the same day but we need a mechanism that can decide which event to go to instead of just following the order now.
tobiichi3227 commented 2025-01-13 15:10:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What mechanism do you think should be used to handle this issue, randomly selecting one from all the repeated events?

What mechanism do you think should be used to handle this issue, randomly selecting one from all the repeated events?
lifeadventurer commented 2025-01-13 15:38:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What mechanism do you think should be used to handle this issue, randomly selecting one from all the repeated events?

Maybe not randomly but generated from the hash function. (We might need to refactor the hash function first btw...)

> What mechanism do you think should be used to handle this issue, randomly selecting one from all the repeated events? Maybe not randomly but generated from the hash function. (We might need to refactor the hash function first btw...)
tobiichi3227 commented 2025-01-13 15:50:04 +00:00 (Migrated from github.com)
Copy Link
Copy Source

OK.
That makes more sense.
@ChenKaiLiuG and I, along with others, suggested not to refactor the hash function's calculation method or results, but only to refactor the way the function is written.
This hash function possesses a certain mystique, accurately predicting many things.

OK. That makes more sense. @ChenKaiLiuG and I, along with others, suggested not to refactor the hash function's calculation method or results, but only to refactor the way the function is written. This hash function possesses a certain mystique, accurately predicting many things.
lifeadventurer commented 2025-01-15 07:59:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I think this function can be refactored and separated to make it reusable.

I think this function can be refactored and separated to make it reusable.
tobiichi3227 commented 2025-01-15 14:38:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Indeed, just like in this kind of scenario.

Indeed, just like in this kind of scenario.
tobiichi3227 commented 2025-02-06 09:27:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I will rebase it.

I will rebase it.
tobiichi3227 commented 2025-02-06 09:40:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@LifeAdventurer Rebase fininshed

@LifeAdventurer Rebase fininshed
lifeadventurer (Migrated from github.com) requested changes 2025-02-06 09:49:05 +00:00
fortune_generator/json/static_special.json
@@ -20,6 +20,46 @@
"r_2_desc": ""
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:47:59 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:48:51 +00:00
Copy Link
Copy Source

Keep this event and description blank.

Keep this event and description blank.
fortune_generator/json/static_special.json
@@ -40,6 +80,166 @@
"r_2_desc": ""
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:45:59 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:46:33 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:46:42 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:47:21 +00:00
Copy Link
Copy Source

Keep this event and description blank.

Keep this event and description blank.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:47:29 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:47:44 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) commented 2025-02-06 09:47:51 +00:00
Copy Link
Copy Source

Shorten this description.

Shorten this description.
lifeadventurer (Migrated from github.com) approved these changes 2025-02-06 13:08:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
lifeadventurer
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 stale
Pull Request is stale
 waiting for merge
waiting for review
waiting for update
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ChenKaiLiuG
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ChenKaiLiuG/life_generators#48