From c36cc8a14b83efada42aa2d30361fcea6b7e3128 Mon Sep 17 00:00:00 2001 From: lifeadventurer Date: Fri, 24 Nov 2023 23:51:55 +0800 Subject: [PATCH] refactor: improve readability in scripts.js --- scripts.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts.js b/scripts.js index 4002d12..d6dafac 100644 --- a/scripts.js +++ b/scripts.js @@ -9,15 +9,14 @@ async function fetch_folders(){ // console.log(folderPaths); }) } - -const repoOwner = 'LifeAdventurer'; -const repoName = 'generators'; -async function generator_card_footer(){ +async function get_generator_card_footer(){ await fetch_folders() // console.log(folderPaths); - for(let i = 0; i < folderPaths.length; i++){ - let folderPath = folderPaths[i]; + const repoOwner = 'LifeAdventurer'; + const repoName = 'generators'; + for(let folderIndex = 0; folderIndex <= folderPaths.length; folderIndex++){ + let folderPath = folderPaths[folderIndex]; const apiUrl = `https://api.github.com/repos/${repoOwner}/${repoName}/commits?path=${folderPath}`; console.log(apiUrl); @@ -31,14 +30,14 @@ async function generator_card_footer(){ const timeDifference = currentTimeStamp - commitTimeStamp; // console.log(timeSinceLastUpdate); - $(`#last-update-${i + 1}`).html(`Last updated ${formatTimeDifference(timeDifference)} ago`) + $(`#last-update-${folderIndex}`).html(`Last updated ${format_time_difference(timeDifference)} ago`) }) - .catch(error => console.error('Error fetching data:', error)); + // .catch(error => console.error('Error fetching data:', error)); } } // determine whether it is seconds, minutes, hours, or days ago -function formatTimeDifference(seconds) { +function format_tim_difference(seconds) { const minutes = Math.floor(seconds / 60); const hours = Math.floor(minutes / 60); const days = Math.floor(hours / 24); @@ -57,4 +56,4 @@ function formatTimeDifference(seconds) { } } -generator_card_footer() \ No newline at end of file +get_generator_card_footer() \ No newline at end of file