From aa6376fdb119e1a92c737cea99ecfc2890a20be1 Mon Sep 17 00:00:00 2001 From: Moon <108756201+LifeAdventurer@users.noreply.github.com> Date: Fri, 22 Dec 2023 18:00:35 +0800 Subject: [PATCH] impr: rename variable and refactor if statement condition --- fortune_generator/fortune.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fortune_generator/fortune.js b/fortune_generator/fortune.js index 4cc2c11..a41ef84 100644 --- a/fortune_generator/fortune.js +++ b/fortune_generator/fortune.js @@ -26,7 +26,7 @@ fetch("https://api.ipify.org?format=json").then(response => { let goodFortunes = []; let badFortunes = []; let special_events = []; -var is_already_gen_fortune = false; +var fortune_generated = false; // using async and await to prevent fetching the data too late... async function fetch_data(){ @@ -145,7 +145,7 @@ async function init_page(){ let now_date = new Date(); let last_date = new Date(last_date_str); if (now_date.getFullYear() === last_date.getFullYear() && now_date.getMonth() === last_date.getMonth() && now_date.getDate() === last_date.getDate()) { - is_already_gen_fortune = true; + fortune_generated = true; Appear(); } } @@ -175,7 +175,7 @@ function Appear() { let seed1 = -1; let seed2 = -1; - if (!is_already_gen_fortune) { + if (fortune_generated == false) { // transform ip to four numbers let num = ip.split(".").map(num => parseInt(num));